Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add synonym operation summaries #3220

Merged
merged 3 commits into from
Dec 5, 2024
Merged

[DOCS] Add synonym operation summaries #3220

merged 3 commits into from
Dec 5, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 4, 2024

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 27/27 27/27

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review December 4, 2024 00:09
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 27/27 27/27

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@marciw marciw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ number style tweak

specification/synonyms/put_synonym/SynonymsPutRequest.ts Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
synonyms.delete_synonym_rule 🟢 7/7 7/7
synonyms.delete_synonym 🟢 6/6 6/6
synonyms.get_synonym_rule 🟢 4/4 4/4
synonyms.get_synonym 🟢 16/16 16/16
synonyms.get_synonyms_sets 🟢 6/6 6/6
synonyms.put_synonym_rule 🟢 4/4 4/4
synonyms.put_synonym 🟢 27/27 27/27

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 6fbd2ba into main Dec 5, 2024
7 checks passed
@lcawl lcawl deleted the synonyms-summary branch December 5, 2024 00:56
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit 6fbd2ba)
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit 6fbd2ba)
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit 6fbd2ba)
lcawl added a commit that referenced this pull request Dec 5, 2024
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit 6fbd2ba)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 5, 2024
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit 6fbd2ba)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Dec 5, 2024
Co-authored-by: Marci W <[email protected]>
(cherry picked from commit 6fbd2ba)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants